Phrasemaker to ES6

[ricknjacky]

In continuation of #2656

[walterbender]

js/widgets/phrasemaker.js:4019 Uncaught TypeError: this.getAttribute is not a function
at HTMLTableCellElement.cell.onmouseover (js/widgets/phrasemaker.js:4019)

Did you test this? This error happens when I try to click on a cell.

[ricknjacky]

I have rectified the error.

[walterbender]

js/widgets/phrasemaker.js:4848 Uncaught (in promise) ReferenceError: delta is not defined
at PitchTimeMatrix._save (js/widgets/phrasemaker.js:4848)
at HTMLDivElement.widgetWindow.addButton.onclick (js/widgets/phrasemaker.js:261)

when trying to save...

Please check all of the widget functionality.

[ricknjacky]

Please check all of the widget functionality.

Sorry, didn't test all of them last time, now all the buttons and their respective functionalities were tested. They worked correctly.

[meganindya]

This file is actually very convoluted. Semantics look good, but I am still not sure we know enough ways to extensively test this widget and figure out if any crash occurs, that is due to this or it previously existed.

[meganindya]

This change isn't helping very much anyway. Lot's of remaining var occurrences that'll be tricky to remove. I've a better advice.

[meganindya]

How about you convert this to a class definition first. Move the constants outside. Only the variables at the top go inside the constructor, the rest functions declared like this.SOMETHING = function(...) { ... } become SOMETHING(...) { ... }

[meganindya]

This itself will expose a lot of bugs, e.g. variables declared without var/let/const

[walterbender]

FYI, I am about 50% of the way through doing the var --> let conversion. A few tricky bits. I'll let you know when I am done.

[walterbender]

The var --> let conversion is complete and I gave the code a pretty thorough going over. I don't think there are any regressions. Should be ready for the arrow function updates now.

[meganindya]

So we can close this right?

[ricknjacky]

ig, we should and I'll start with porting to arrow functions asap.