adding classes to pluginviewer.js #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganindya
reviewed
Dec 5, 2020
js/pluginsviewer.js
Outdated
| } | ||
|
|
||
| function hideCurrentPage(viewer) { | ||
| const hideCurrentPage = (viewer) => { |
There was a problem hiding this comment.
This is a top level function. Should remain function FNAME(...) { ... }
meganindya
reviewed
Dec 5, 2020
js/pluginsviewer.js
Outdated
| @@ -222,7 +203,7 @@ function hideCurrentPage(viewer) { | |||
| viewer.refreshCanvas(); | |||
| } | |||
|
|
|||
| function showNextPage(viewer) { | |||
| const showNextPage = (viewer) => { | |||
There was a problem hiding this comment.
This is a top level function. Should remain function FNAME(...) { ... }
meganindya
reviewed
Dec 5, 2020
js/pluginsviewer.js
Outdated
| @@ -239,7 +220,7 @@ function showNextPage(viewer) { | |||
| viewer.refreshCanvas(); | |||
| } | |||
|
|
|||
| function viewerClicked(viewer, event) { | |||
| const viewerClicked = (viewer, event) => { | |||
There was a problem hiding this comment.
This is a top level function. Should remain function FNAME(...) { ... }
meganindya
reviewed
Dec 5, 2020
js/pluginsviewer.js
Outdated
| @@ -264,7 +245,7 @@ function viewerClicked(viewer, event) { | |||
| } | |||
| } | |||
|
|
|||
| function loadThumbnailContainerHandler(viewer) { | |||
| const loadThumbnailContainerHandler = (viewer) => { | |||
There was a problem hiding this comment.
This is a top level function. Should remain function FNAME(...) { ... }
meganindya
reviewed
Dec 5, 2020
js/pluginsviewer.js
Outdated
| @@ -315,11 +296,11 @@ function loadThumbnailContainerHandler(viewer) { | |||
| }); | |||
| } | |||
|
|
|||
| function makeViewerBitmap(viewer, data, name, callback, extras) { | |||
| const makeViewerBitmap = (viewer, data, name, callback, extras) => { | |||
There was a problem hiding this comment.
This is a top level function. Should remain function FNAME(...) { ... }
meganindya
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #2629