callback to arrow function #2634
Conversation
sj00coder
changed the title
|
If not yet complete ... please mark as draft PR. |
Sir,Please check some of my changes,if that is okay,I'll continue rest of my work.Please |
|
Fixed the merge conflict for you. Please get rid of the remaining instances of |
In callbacks, there is no 'that' instances are left sir @meganindya .I have did it before.or I am supposed to do it in whole js files with every instance of that. |
|
@meganindya , Sir In my first commits I have not did remove that's but in latter commits I have did it all.Please review this sir. |
| <<<<<<< HEAD | ||
| <<<<<<< HEAD | ||
|
|
||
| var inputNum1 = this._musicRatio1.value; | ||
| ======= | ||
| let that = this; | ||
| let inputNum1 = this._musicRatio1.value; | ||
| >>>>>>> upstream/master | ||
| ======= | ||
| let that = this; | ||
| let inputNum1 = this._musicRatio1.value; | ||
| >>>>>>> 446b179e34ba9e0c1252d6effd06341b9c486707 |
There was a problem hiding this comment.
Why does your committed code have this stuff?
js/widgets/rhythmruler.js
Outdated
| <<<<<<< HEAD | ||
|
|
||
| // FIXME: Should be based on meter | ||
| for (var i = 0; i < 4; i++) { | ||
| setTimeout(() => { | ||
| this._logo.synth.trigger( | ||
| ======= | ||
| let that = this; | ||
| // FIXME: Should be based on meter | ||
| for (let i = 0; i < 4; i++) { | ||
| setTimeout(function() { | ||
| that._logo.synth.trigger( | ||
| >>>>>>> upstream/master |
There was a problem hiding this comment.
Didn't fix merge conflicts properly
|
Can't follow so many files at once. Please follow the following:
one file at a time, except for those with less than 20 line differences. |
|
I'm closing this PR. Follow the steps above for new PRs. |
#2629 Callback to arrow functions