Porting Var-> Let for timbre, tempo and temperament

[ricknjacky]

fix for #2629

[meganindya]

Pls do not create so many commits. It's harder to follow.

[ricknjacky]

The timbre file is quite huge, in each commit pertaining to it that I've pushed above, abided by scoping rules and has message for the same. For the ease of debugging/review I actually practiced this behaviour.

Point noted. Will just push commit for one and only one file, from now on

PS:- any discrepancy in the commits?

[meganindya]

Also, please name the PR based on what you've done. If you use the name similar to an issue, it needs to completely address that issue.

[meganindya]

The timbre file is quite huge, in each commit pertaining to it that I've pushed above, abided by scoping rules and has message for the same. For the ease of debugging/review I actually practiced this behaviour.

don't make large number of changes per PR :p

[ricknjacky]

don't make large number of changes per PR :p

Point noted! FWIW pardon me for this one then O_o
Will get back to making changes for rest of the files ASAP :)

[ricknjacky]

Also, please name the PR based on what you've done. If you use the name similar to an issue, it needs to completely address that issue.

I changed it

don't make large number of changes per PR :p

I'll do the changes for remaining files in new PRs respectively, right ? @meganindya

[meganindya]

use const wherever appropriate ... leftover vars in timbre.js

[meganindya]

Let's not clutter this PR anymore. Please wrap up any pending work.