Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clear option #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DipanshKhandelwal
Copy link
Contributor

issue #14 .
This will clear canvas.

@walterbender
Copy link
Member

Two issues:
(1) I would have thought the clear would just cleat the drawing, not the dots.
(2) the clear button itself should be on the left, not next to the stop button. Plus it is not rendering properly for me.

@DipanshKhandelwal
Copy link
Contributor Author

@walterbender issue (2) solved ,it will render properly and now its on the left side of tool bar.
conn

@walterbender
Copy link
Member

Black on dark gray is hard to read. Maybe you can grab a trash icon from another project, e.g., https://github.com/sugarlabs/physics/blob/master/icons/clear_all.svg

@DipanshKhandelwal
Copy link
Contributor Author

Ok thanks 👍

@DipanshKhandelwal
Copy link
Contributor Author

DipanshKhandelwal commented Dec 26, 2017

@walterbender take a look at the changes once.
1

@walterbender
Copy link
Member

Everything is much improved, except that the clear button should not erase the current set of dots, just the drawing. (or it should restore the current set of dots after clearing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants