Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(safety): implement basic shutdown interrupt #192

Merged
merged 8 commits into from
Jan 31, 2023
Merged

feat(safety): implement basic shutdown interrupt #192

merged 8 commits into from
Jan 31, 2023

Conversation

t-bre
Copy link
Member

@t-bre t-bre commented Jan 31, 2023

Changes

  • Creates falling edge interrupt on shutdown pin.
  • Note the temporary patch for CAN initialisation. This should be fixed by develop in the same way and not cause any conflicts.

Fixed Issue(s)

WIP for #167

Checklist

  • Code has been tested on STM32 hardware.
  • Changes do not generate any new compiler warnings.
  • Code has been formatted using trunk fmt.
  • Commit messages follow the Conventional Commits specification.

@t-bre t-bre added the feature New features label Jan 31, 2023
@t-bre t-bre added this to the STAG 9 milestone Jan 31, 2023
@t-bre t-bre self-assigned this Jan 31, 2023
@t-bre t-bre changed the base branch from main to develop January 31, 2023 22:00
@t-bre t-bre merged commit 19bda14 into develop Jan 31, 2023
@t-bre t-bre changed the title feat(shutdown): implement basic shutdown interrupt feat(safety): implement basic shutdown interrupt Jan 31, 2023
@t-bre t-bre deleted the shutdown_interrupt branch January 31, 2023 22:02
t-bre added a commit that referenced this pull request Mar 3, 2023
@t-bre @jammyb1 @Scaniox
feat: port STAG8 codebase to STM32F7 (#197)
786190d 
* build!: port to STM32-F746ZG (#156)

* chore(cubemx): bump .ioc for v6.6.1 compatibility

* build: initial port to STM32F7

* chore: delete unnecessary CMSIS driver files

* chore: add CMSIS driver files

* chore(git): update .gitignore

* build: add missing driver file

* chore: update .ioc

* build: add ThreadX middlewares

* build: re-generate ThreadX code with STM32CubeMX

* build: update Makefile for ThreadX build

* build: re-setup .ioc configuration for ADCs and LEDs

* chore(git): update .gitignore

* feat(can): initial start of converting FDCAN drivers to CAN

* build: remove illegal character in makefile

* feat(can): setup second CAN bus for sensors (#158)

* fix(debug): prevent debugger stopping on every TIM3 interrupt

* feat(debug): update SVD file for STM32F7

* feat(trunk): move cppcheck misra rule texts to trunk configs folder

* feat(can): create CAN broadcasting service (#162)

* feat(can): minimal working logging test

* feat(can): create initial RTOS CAN service functions

* fix(can): correct MISRA issues

* feat(can): create RTCAN thread service

* feat(can): add queuing system to RTCAN service

* perf(can): remove redundant memcpy from RTCAN transmit

* style: rename 'context' to 'handle' in RTCAN service

* style: new `_h` prefix for handles

* feat(can): create CAN broadcast system

* feat(can): post to RTCAN semaphore in CAN transmit callback

* chore: remove test code from CAN broadcast thread

* refactor!: encapsulate control and driver inputs module states in context structs (#168)

* refactor(vcu): start encapsulating VCU in context struct

* refactor(vcu): move initialisation thread to VCU module

* refactor(control)!: encapsulate control thread with context struct

this breaks a few things, other threads need to be updated once refactored in a similar way

* refactor(sensors)!: restructure sensor thread into driver control service

* chore!: remove old inverter driver (#171)

* chore!: purge old CAN drivers

* chore(vscode): update settings

* chore(trunk): update cppcheck config (#172)

* style: apply formatting

* chore(trunk): update cppcheck config (disable MISRA for now)

* fix(can): make CAN handle in RTCAN mailbox callback const

* style: apply formatting

* refactor(apps): improve const correctness in internal functions

* chore!: purge old watchdog and fault handler (#173)

* feat(can): broadcast APPS and BPS readings (#175)

* feat(can): add tick timer to CANBC service

* fix(can): remove unused variable assignment

* fix(can): correct item size of CANBC memory pools

* feat(can): add broadcasting of APPS and BPS readings

* chore(vscode): update paths for new STM32F7 MCU

* docs: update links in README

* chore(vscode): add basic Windows configs

* chore(vscode): set up Windows configurations (#188)

* chore(vscode): adding windows configuration

* chore(vscode): removing some redundant auto-generated code

* chore(vscode): updating 'c_cpp_properties' to try and get intellisense to work

* chore(vscode): fixedls -a!

* chore(vscode): moved compile_commands.json to root directory

* feat(can): create outline PM100DZ inverter driver (#190)

* build: fixed a typo in the Makefile include paths

* feat(can): create outline functions for PM100 inverter driver

* feat(safety): create `status_t` for all status codes

need to refactor old modules to use this

* feat(can): update CAN bitrates and use pull-ups

* feat(can): instantiate PM100 driver

* chore(can): add CAN definitions submodule

* feat(can): draft implementation of inverter driver

* chore(vscode): update include paths

* docs: update outdated links in README

* docs: add development environment and contributing info to README (#191)

* chore: add STM32CubeMX generated Makefile to .gitignore

* docs: add info about CubeMX generated Makefile to README

* feat(shutdown): implement basic shutdown interrupt (#192)

* feat(safety): set `SHUTDOWN_IN` to falling edge interrupt and rebuilt HAL

* refactor: remove old shutdown code

* feat(safety): set user button b1 to interrupt on pc13

* fix(can): temporarily patch CAN initialisation to fix shutdown

* style: apply formatting

---------

Co-authored-by: Scaniox <[email protected]>

* chore: cleanup partially complete PM100DZ driver (#193)

* chore: remove old `can-defs` submodule

* fix(can): temporary fix to build incomplete PM100DZ driver

* feat(can): add RTCAN as submodule

* docs: add info on submodules to README

* build: add RTCAN as submodule to build system

* feat: updated driver for PM100 inverter (#196)

* chore: update RTCAN to latest version

* feat: integrate RTCAN

* feat: add `can-defs` submodule

* chore: clear out old PM100 driver code

* style: apply formatting

* feat: basic working inverter control

* chore: update RTCAN submodule

* feat: minor config tweaks

---------

Co-authored-by: James Betson <[email protected]>
Co-authored-by: Scaniox <[email protected]>
inventor02 added a commit that referenced this pull request Nov 7, 2023
@inventor02 @t-bre
@jammyb1 @Scaniox @tgodfrey0
chore: merge develop into main (#220)
e2318ae 
* build!: port to STM32-F746ZG (#156)

* chore(cubemx): bump .ioc for v6.6.1 compatibility

* build: initial port to STM32F7

* chore: delete unnecessary CMSIS driver files

* chore: add CMSIS driver files

* chore(git): update .gitignore

* build: add missing driver file

* chore: update .ioc

* build: add ThreadX middlewares

* build: re-generate ThreadX code with STM32CubeMX

* build: update Makefile for ThreadX build

* build: re-setup .ioc configuration for ADCs and LEDs

* chore(git): update .gitignore

* feat(can): initial start of converting FDCAN drivers to CAN

* build: remove illegal character in makefile

* feat(can): setup second CAN bus for sensors (#158)

* fix(debug): prevent debugger stopping on every TIM3 interrupt

* feat(debug): update SVD file for STM32F7

* feat(trunk): move cppcheck misra rule texts to trunk configs folder

* feat(can): create CAN broadcasting service (#162)

* feat(can): minimal working logging test

* feat(can): create initial RTOS CAN service functions

* fix(can): correct MISRA issues

* feat(can): create RTCAN thread service

* feat(can): add queuing system to RTCAN service

* perf(can): remove redundant memcpy from RTCAN transmit

* style: rename 'context' to 'handle' in RTCAN service

* style: new `_h` prefix for handles

* feat(can): create CAN broadcast system

* feat(can): post to RTCAN semaphore in CAN transmit callback

* chore: remove test code from CAN broadcast thread

* refactor!: encapsulate control and driver inputs module states in context structs (#168)

* refactor(vcu): start encapsulating VCU in context struct

* refactor(vcu): move initialisation thread to VCU module

* refactor(control)!: encapsulate control thread with context struct

this breaks a few things, other threads need to be updated once refactored in a similar way

* refactor(sensors)!: restructure sensor thread into driver control service

* chore!: remove old inverter driver (#171)

* chore!: purge old CAN drivers

* chore(vscode): update settings

* chore(trunk): update cppcheck config (#172)

* style: apply formatting

* chore(trunk): update cppcheck config (disable MISRA for now)

* fix(can): make CAN handle in RTCAN mailbox callback const

* style: apply formatting

* refactor(apps): improve const correctness in internal functions

* chore!: purge old watchdog and fault handler (#173)

* feat(can): broadcast APPS and BPS readings (#175)

* feat(can): add tick timer to CANBC service

* fix(can): remove unused variable assignment

* fix(can): correct item size of CANBC memory pools

* feat(can): add broadcasting of APPS and BPS readings

* chore(vscode): update paths for new STM32F7 MCU

* docs: update links in README

* chore(vscode): add basic Windows configs

* chore(vscode): set up Windows configurations (#188)

* chore(vscode): adding windows configuration

* chore(vscode): removing some redundant auto-generated code

* chore(vscode): updating 'c_cpp_properties' to try and get intellisense to work

* chore(vscode): fixedls -a!

* chore(vscode): moved compile_commands.json to root directory

* feat(can): create outline PM100DZ inverter driver (#190)

* build: fixed a typo in the Makefile include paths

* feat(can): create outline functions for PM100 inverter driver

* feat(safety): create `status_t` for all status codes

need to refactor old modules to use this

* feat(can): update CAN bitrates and use pull-ups

* feat(can): instantiate PM100 driver

* chore(can): add CAN definitions submodule

* feat(can): draft implementation of inverter driver

* chore(vscode): update include paths

* docs: update outdated links in README

* docs: add development environment and contributing info to README (#191)

* chore: add STM32CubeMX generated Makefile to .gitignore

* docs: add info about CubeMX generated Makefile to README

* feat(shutdown): implement basic shutdown interrupt (#192)

* feat(safety): set `SHUTDOWN_IN` to falling edge interrupt and rebuilt HAL

* refactor: remove old shutdown code

* feat(safety): set user button b1 to interrupt on pc13

* fix(can): temporarily patch CAN initialisation to fix shutdown

* style: apply formatting

---------

Co-authored-by: Scaniox <[email protected]>

* chore: cleanup partially complete PM100DZ driver (#193)

* chore: remove old `can-defs` submodule

* fix(can): temporary fix to build incomplete PM100DZ driver

* feat(can): add RTCAN as submodule

* docs: add info on submodules to README

* build: add RTCAN as submodule to build system

* feat: updated driver for PM100 inverter (#196)

* chore: update RTCAN to latest version

* feat: integrate RTCAN

* feat: add `can-defs` submodule

* chore: clear out old PM100 driver code

* style: apply formatting

* feat: basic working inverter control

* chore: update RTCAN submodule

* feat: minor config tweaks

* chore: update launch configs (#214)

* chore: update launch configs

* chore: remove redundant parts

* build: use ${MAKE} instead of make in Makefile (#215)

chore(build): use ${MAKE} instead of make in Makefile

* chore: update CubeMX conf (#216)

* chore: update cubemx project

* chore: update makefile

* chore: rename files

* chore: add ccd target to Makefile (#217)

* chore: add ccd make target

* chore: update README

* chore: make python3 a make var

* chore: show build

* chore: update README to exclude CubeMX reports

* chore: update Makefile

* chore: fix Makefile

* gitignore and submodule update

* makefile for dual can buses

---------

Co-authored-by: Tim Brewis <[email protected]>
Co-authored-by: Timothy Brewis (tab1g19) <[email protected]>
Co-authored-by: James Betson <[email protected]>
Co-authored-by: Scaniox <[email protected]>
Co-authored-by: Toby Godfrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@t-bre t-bre

Labels
feature New features
Projects
None yet
Milestone
STAG 9
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bre @Scaniox