Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the true number of cores avaliable #125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use the true number of cores avaliable #125

wants to merge 3 commits into from
+18 −1

Conversation

satbirkira
Copy link

Screen Shot 2024-11-05 at 10 26 13 PM Screen Shot 2024-11-05 at 10 26 19 PM

sudara
sudara reviewed Nov 6, 2024
View reviewed changes
Copy link
Owner

@sudara sudara left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can remove the parallel argument entirely from the build command — ninja will adapt to the number of cores available (the argument is leftover from pre-ninja times).

When in doubt, doing a few tests for each condition will make it clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudara sudara sudara left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satbirkira @sudara