Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: u256x2048mul precompile #1522

Open
wants to merge 22 commits into
base: tamir/v1.3.0-rc2
Choose a base branch
from
Open

feat: u256x2048mul precompile #1522

wants to merge 22 commits into from

Conversation

umadayal
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: uma-dayal/rsa
Commit: 9b6e213d
Author: umadayal

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 4.62 0.43 27s ✅
ssz-withdrawals 2757356 11.77 71.91 37.18 1m14s ✅
tendermint 12593597 5.52 180.54 105.21 2m2s ✅

kevjue
kevjue reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@kevjue kevjue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a thorough review yet, but please address the following style comments.

.vscode/settings.json Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/core/executor/Cargo.toml Outdated Show resolved Hide resolved
crates/core/executor/src/events/precompiles/u256x2048_mul.rs Show resolved Hide resolved
crates/core/executor/src/record.rs Outdated Show resolved Hide resolved
crates/core/executor/src/syscalls/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
kevjue
kevjue reviewed Sep 25, 2024
View reviewed changes
crates/core/executor/src/events/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
crates/core/executor/src/syscalls/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
crates/core/executor/src/syscalls/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
crates/core/executor/src/syscalls/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
crates/core/executor/src/syscalls/precompiles/u256x2048_mul.rs Outdated Show resolved Hide resolved
crates/core/machine/src/syscall/precompiles/u256x2048_mul/air.rs Outdated Show resolved Hide resolved
crates/core/machine/src/syscall/precompiles/u256x2048_mul/air.rs Outdated Show resolved Hide resolved
crates/core/machine/src/syscall/precompiles/u256x2048_mul/air.rs Outdated Show resolved Hide resolved
crates/core/machine/src/syscall/precompiles/u256x2048_mul/air.rs Show resolved Hide resolved
crates/core/machine/src/syscall/precompiles/u256x2048_mul/air.rs Outdated Show resolved Hide resolved
@umadayal umadayal changed the base branch from dev to tamir/v1.3.0-rc2 September 26, 2024 00:48
@umadayal umadayal changed the base branch from tamir/v1.3.0-rc2 to dev November 7, 2024 02:34
@umadayal umadayal changed the base branch from dev to tamir/v1.3.0-rc2 November 7, 2024 20:22
@umadayal umadayal changed the base branch from tamir/v1.3.0-rc2 to dev November 7, 2024 20:22
@umadayal umadayal changed the base branch from dev to tamir/v1.3.0-rc2 November 7, 2024 20:25
@nhtyy nhtyy added the maybe-stale A pr or issue that hasnt seen alot of activity recently label Nov 20, 2024
@nhtyy nhtyy added next-release A PR or an issue that should resolved before the next major release and removed maybe-stale A pr or issue that hasnt seen alot of activity recently labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtguibas jtguibas jtguibas left review comments

@kevjue kevjue kevjue left review comments

Assignees
No one assigned
Labels
next-release A PR or an issue that should resolved before the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umadayal @kevjue @jtguibas @nhtyy