Skip to content

DiveSystem: Handle APOS5 sample record alias fix. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zorcik wants to merge 1 commit into from
+5 −5
Closed

DiveSystem: Handle APOS5 sample record alias fix. #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/divesystem_idive_parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

#define REC_SAMPLE 0
#define REC_INFO 1
#define REC_SAMPLE_APOS5_COMPAT 0x8006
#define REC_SAMPLE_APOS5_COMPAT 0x8000

typedef struct divesystem_idive_parser_t divesystem_idive_parser_t;

Expand Down Expand Up @@ -467,10 +467,10 @@ divesystem_idive_parser_samples_foreach (dc_parser_t *abstract, dc_sample_callba
unsigned int type = ISIX3M(parser->model) ?
array_uint16_le (data + offset + 52) :
REC_SAMPLE;
// AI-generated (Claude)
// APOS5 uses 0x8006 for ordinary profile samples. Keep this alias
// narrow until the record type is confirmed by the vendor.
if (firmware_major >= 5 && type == REC_SAMPLE_APOS5_COMPAT)
// APOS5 firmware uses various record type values for ordinary
// profile samples (0x8006, 0x800E observed). The high bit 0x8000
// appears to flag sample records in APOS5.
if (firmware_major >= 5 && (type & REC_SAMPLE_APOS5_COMPAT))
type = REC_SAMPLE;
if (type != REC_SAMPLE) {
if (type == REC_INFO) {
Expand Down