Add test cases for bitwise not for decimal type#95
Open
anshuldata wants to merge 1 commit intosubstrait-io:mainfrom
Open
Add test cases for bitwise not for decimal type#95anshuldata wants to merge 1 commit intosubstrait-io:mainfrom
anshuldata wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
anshuldata
force-pushed
the
BitwiseNotDecimalFunc_New
branch
from
a87ff5f to
b73929b
Compare
Contributor
Author
|
rebased it |
richtia
reviewed
Sep 16, 2024
| description: Basic examples without any special cases | ||
| args: | ||
| - value: 0 | ||
| type: decimal<38, 0> |
Member
There was a problem hiding this comment.
should we do decimal<1, 0>? Make it more precise, like we did to all the other decimal yamls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.