Skip to content

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Sep 6, 2025

Description

Added querying historical data by block range

Fixes #1887

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@Gmin2
Copy link
Contributor Author

Gmin2 commented Sep 9, 2025

@stwiname can i get a review on this ?

@stwiname
Copy link
Collaborator

@Gmin2, it's on my radar, i just havent found the time for it

@Gmin2
Copy link
Contributor Author

Gmin2 commented Sep 11, 2025

Hey @stwiname I need to discuss somethings with yu can yu give me your tele or any social where i can dm yu

@stwiname
Copy link
Collaborator

Copy link
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gmin2, sorry for the delay reviewing this.

This is looking really good and on the right track. I've just got high level comments for now.

  • The historical snapshot data looks to be missing the block range now
  • It would be good for your PR description to include some more details on what needs to be done still and any concerns or unknowns
  • I had a quick play around with some block range queries and the responses aren't updated
    • A single entity query still returns a single result
    • A multi entity query filtered to a single id returns multiple results but it doesn't include the block data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$3000 in SQT] Allow query historical data by block range
2 participants