Refactor NAT discovery unit tests to use the public Interface #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the remote Endpoint tests wrote directly to the local instance UDP channel and forwarded to the parseAndHandleMessageFromAddress method. However this bypassed the listener loop and its setup, losing code coverage. This commit adds a ServerConnection interface abstraction allowing the unit tests to only mock the UDP read/write functions and utilize the listener loop. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr3334/tpantelis/nat_disc |
tpantelis
force-pushed
the
nat_disc
branch
2 times, most recently
from
1cdc79f to
deba4e3
Compare
This makes them more "whitebox" and moves the files to the "natdiscovery_test" package to avoid leakage of test code into the production package. This should also make a bit easier to implement IPv6. Two of the test files, request_handle_internal_test.go and listener_internal_test.go, were not moved to the test package as they test specific internal functions which would entail making too much of the production code public. A new function, NewWithConfig, was added that allows the unit tests to construct the natDiscovery instance with hooks to mock behavior. Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them more "whitebox" and moves the files to the
natdiscovery_testpackage to avoid leakage of test code into the production package. This will also make it a bit easier to implement IPv6.Two of the test files, request_handle_internal_test.go and listener_internal_test.go, were not moved to the test package as they test specific internal functions which would entail making too much of the production code public.
A new function,
NewWithConfig, was added that allows the unit tests to construct thenatDiscoveryinstance with hooks to mock behavior.