Skip UPX compression when building images for linting

UPX compression takes a significant amount of time, and is pointless
for throwaway images such as those built for linting jobs.

Signed-off-by: Stephen Kitt <[email protected]>

Author: skitt

.github/workflows/linting.yml

@@ -62,7 +62,7 @@ jobs:
       - name: Check out the repository
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
       - name: Run golangci-lint
-        run: make golangci-lint
+        run: make golangci-lint UPX_LEVEL=-0
 
   markdown-link-check:
     name: Markdown Links (modified files)
@@ -94,7 +94,7 @@ jobs:
       - name: Check out the repository
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
       - name: Run packagedoc-lint
-        run: make packagedoc-lint
+        run: make packagedoc-lint UPX_LEVEL=-0
 
   shellcheck:
     name: Shell

Makefile.images

@@ -12,6 +12,7 @@ export REPO ?= quay.io/submariner
 
 # Specific to `build_images.sh`
 export USE_CACHE ?= true
+export UPX_LEVEL
 
 # Specific to `images`
 export OCIFILE PLATFORM

package/Dockerfile.shipyard-dapper-base

@@ -72,7 +72,7 @@ RUN dnf -y install --nodocs --setopt=install_weak_deps=False \
     dnf -y clean all && \
     rm -f /usr/bin/{dockerd,lto-dump} \
           /usr/libexec/gcc/x86_64-redhat-linux/10/lto1 && \
-    find /usr/bin /usr/lib/golang /usr/libexec -type f -executable -newercc /proc -size +1M ! -name hyperkube \( -execdir upx ${UPX_LEVEL} {} \; -o -true \) && \
+    [ "${UPX_LEVEL}" = -0 ] || find /usr/bin /usr/lib/golang /usr/libexec -type f -executable -newercc /proc -size +1M ! -name hyperkube \( -execdir upx ${UPX_LEVEL} {} \; -o -true \) && \
     ln -f /usr/bin/kubectl /usr/bin/hyperkube
 
 COPY tools/go.mod /tools.mod

scripts/shared/build_image.sh

@@ -56,6 +56,7 @@ fi
 
 # Rebuild the image to update any changed layers and tag it back so it will be used.
 buildargs_flags=(--build-arg BUILDKIT_INLINE_CACHE=1 --build-arg "BASE_BRANCH=${BASE_BRANCH}" --build-arg "VERSION=${VERSION}")
+[[ -z "${UPX_LEVEL}" ]] || buildargs_flags+=(--build-arg "UPX_LEVEL=${UPX_LEVEL}")
 if [[ "${PLATFORM}" != "${default_platform}" ]] && docker buildx version > /dev/null 2>&1; then
     docker buildx use buildx_builder || docker buildx create --name buildx_builder --use
     docker buildx build "${output_flag}" -t "${local_image}" "${cache_flags[@]}" -f "${dockerfile}" --iidfile "${hashfile}" --platform "${PLATFORM}" "${buildargs_flags[@]}" .