Build golangci-lint with the installed Go compiler

golangci-lint fails if the Go environment used to analyse code is
newer than the version it was built with. This isn't usually a problem
on devel because golangci-lint is updated regularly, but it's the main
reason why Go linting jobs fail on release branches: those stay on
older versions of golangci-lint that quickly end up older than the Go
compiler in the base Shipyard image.

This changes the base image construction so that golangci-lint is
always built using the installed compiler.

Signed-off-by: Stephen Kitt <[email protected]>

Author: skitt

package/Dockerfile.shipyard-dapper-base

@@ -77,9 +77,12 @@ RUN dnf -y install --nodocs --setopt=install_weak_deps=False \
 
 COPY tools/go.mod /tools.mod
 
-# This layer's versioning is determined by us, and thus could be rebuilt more frequently to test different versions
+# This layer's versioning is determined by us,
+# and thus could be rebuilt more frequently to test different versions.
+# golangci-lint must be built with a version of Go equal to or newer
+# than the version used to analyse the code, so this rebuilds it.
 RUN LINT_VERSION=$(awk '/golangci-lint/ { print $2 }' /tools.mod) && \
-    curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin -d ${LINT_VERSION} && \
+    go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@${LINT_VERSION} && \
     KIND_VERSION=$(awk '/sigs.k8s.io.kind/ { print $2 }' /tools.mod) && \
     curl -Lo /go/bin/kind "https://github.com/kubernetes-sigs/kind/releases/download/${KIND_VERSION}/kind-linux-${ARCH}" && chmod a+x /go/bin/kind && \
     mkdir -p /usr/local/libexec/docker/cli-plugins && \