[C] Add support for decimal floating-point types #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braewoods
force-pushed
the
c-decimal-types
branch
from
0054f20
to
3b4bea4
Compare
|
The only part I believe to be questionable is the changes related to the |
deathaxe
reviewed
Nov 10, 2024
braewoods
force-pushed
the
c-decimal-types
branch
from
3b4bea4
to
0dbaaed
Compare
|
I have updated the commit to resolve the conflict. |
braewoods
force-pushed
the
c-decimal-types
branch
from
0dbaaed
to
9f7f6da
Compare
|
This revises the matching rule to the simplified version presented earlier by @deathaxe. |
This was introduced in C23 and adds support for the new type keywords, the new suffixes for the new types, and the new length modifiers for printf and scanf. Furthermore, the existing matching rules for floats was changed to remove the possibility of '1f' being classified as a floating point literal. This is actually considered to be an integral literal with an invalid suffix instead of a floating point literal by all compilers that I know of and such produces compiler errors if such code is compiled.
braewoods
force-pushed
the
c-decimal-types
branch
from
9f7f6da
to
22fedcd
Compare
|
I've noticed that hexadecimal floats also need to be updated but I think that's best done in a different PR. |
michaelblyons
approved these changes
Nov 10, 2024
deathaxe
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in C23 and adds support for the new type keywords, the new suffixes for the new types, and the new length modifiers for printf and scanf.
Furthermore, the existing matching rules for floats was changed to remove the possibility of '1f' being classified as a floating point literal. This is actually considered to be an integral literal with an invalid suffix instead of a floating point literal by all compilers that I know of and such produces compiler errors if such code is compiled.