Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSharp] Add the C# 11 type modifier file feature support #4034

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Sep 12, 2024

See https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/file

The file is the keyword of type modifier as the type visibility.

@michaelblyons
Copy link
Collaborator

Do you want to write some unit tests, too?

@lindexi
Copy link
Contributor Author

lindexi commented Sep 12, 2024

Thank you, let me learn how to write unit tests in this project.

@lindexi
Copy link
Contributor Author

lindexi commented Sep 12, 2024

@michaelblyons I added the unit test code, could you review my code?

@michaelblyons
Copy link
Collaborator

I have approved running the tests, but there are some test failures. Once those look good, I think it'll be clear to merge.

@lindexi
Copy link
Contributor Author

lindexi commented Sep 12, 2024

@michaelblyons Thank you and I try fix the unit test. Sorry, I'm not familiar with test syntax.

@michaelblyons
Copy link
Collaborator

If you're having trouble, you can install the PackageDev package, click at end of the line you want tests for in the unit test file, and Cmd+Enter (or Ctrl+Enter) and it should write a test suite for that line.

@deathaxe deathaxe merged commit b451c77 into sublimehq:master Sep 12, 2024
1 check passed
@lindexi lindexi deleted the patch-1 branch September 13, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants