Skip to content

Commit

Permalink
fix(video-quality) Enable TCC support for Firefox 115 and later.
Browse files Browse the repository at this point in the history
Firefox ESR 115 stops sending REMBs to the bridge under certain network conditions making the bridge suspend all video streams sent to the Firefox eps. It is still unclear why Firefox stops sending REMBs so enabling TCC support as workaround since TCC doesn't seem to have issues with uplink BWE in the older versions.
  • Loading branch information
jallamsetty1 authored and subhamcyara committed Jul 19, 2024
1 parent dfc20b9 commit b8e32bd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/xmpp/xmpp.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,9 @@ export default class XMPP extends Listenable {
this.caps.addFeature('http://jitsi.org/remb');
}

// Disable TCC on Firefox 116 and older versions because of a known issue where BWE is halved on every
// Disable TCC on Firefox 114 and older versions because of a known issue where BWE is halved on every
// renegotiation.
if (!(browser.isFirefox() && browser.isVersionLessThan(117))
if (!(browser.isFirefox() && browser.isVersionLessThan(115))
&& (typeof this.options.enableTcc === 'undefined' || this.options.enableTcc)) {
this.caps.addFeature('http://jitsi.org/tcc');
}
Expand Down

0 comments on commit b8e32bd

Please sign in to comment.