-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression script for the V&V repo #1538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! much needed
It would have appreciated a few words though as the title does not give away the added case for example. What is the short-term plan to do with the V&V cases? Are you verifying them all and add them to the reg-test? Maybe link su2code/VandV#3 as an example why we need this.
And is the 30p30n case now a v&v case? It certainly could, but then it currently completely lacks any easy accessible postprocessing results that would make it easy to verify. Especially for V&V cases imo it should be known what result we are aiming for and not just some relative comparison with residuals. But I dont need to tell you that and I am sure you did make some thoughts on all of that... so no essay needed, but a little more pedro -v
for test in test_list: | ||
test.su2_exec = "mpirun -n 2 SU2_CFD" | ||
test.timeout = 300 | ||
test.tol = 1e-5 | ||
#end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do that style for parallel regression too 👍 good idea
Talk is cheap. |
No description provided.