Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: リザルト画面で「ゲームを終了する」ボタンの追加 #80

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

waka-eup25
Copy link
Contributor

やったこと

  • リザルト画面において,「次へ」ボタンを「もう一度プレイする」ボタンに名前を変更
  • 「ゲームを終了する」ボタンを追加した

やらないこと

  • 無し

できるようになること(ユーザ目線)

  • リザルト画面において,「ゲームを終了する」ボタンか「もう一度プレイする」ボタンかどちらかを選択することができる

できなくなること(ユーザ目線)

  • 無し

動作確認

  • yarn buildが通ることを確認
yarn build
   ▲ Next.js 14.1.0
   - Environments: .env

   Creating an optimized production build ...
 ⚠ For production Image Optimization with Next.js, the optional 'sharp' package is strongly recommended. Run 'npm i sharp', and Next.js will use it automatically for Image Optimization.
Read more: https://nextjs.org/docs/messages/sharp-missing-in-production
Compiler server unexpectedly exited with code: null and signal: SIGTERM
 ⚠ For production Image Optimization with Next.js, the optional 'sharp' package is strongly recommended. Run 'npm i sharp', and Next.js will use it automatically for Image Optimization.
Read more: https://nextjs.org/docs/messages/sharp-missing-in-production
Compiler client unexpectedly exited with code: null and signal: SIGTERM
 ✓ Compiled successfully
 ✓ Linting and checking validity of types
 ✓ Collecting page data
 ✓ Generating static pages (7/7)
 ✓ Collecting build traces
 ✓ Finalizing page optimization

Route (app)                              Size     First Load JS
┌ ○ /                                    1.55 kB         258 kB
├ ○ /_not-found                          882 B          85.2 kB
├ ○ /game                                9.37 kB         139 kB
└ ○ /ranking                             1.68 kB         137 kB
+ First Load JS shared by all            84.3 kB
  ├ chunks/69-684208d8427a30a4.js        28.9 kB
  ├ chunks/fd9d1056-780053702ed842a5.js  53.4 kB
  └ other shared chunks (total)          2.04 kB


○  (Static)  prerendered as static content

Copy link
Member

@KinjiKawaguchi KinjiKawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waka-eup25 画面のスクリーンショットがPRにあると嬉しいです!

@waka-eup25
Copy link
Contributor Author

リザルト画面のスクリーンショットです!これで大丈夫でしょうか
result-screen

Copy link
Member

@KinjiKawaguchi KinjiKawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waka-eup25
スクリーンショット、迅速な対応をありがとうございます。

プログラムで一点気になるところがあったので、コメントしておきました。

typing-app/src/components/templates/GameResult.tsx Outdated Show resolved Hide resolved
@KinjiKawaguchi KinjiKawaguchi linked an issue Apr 4, 2024 that may be closed by this pull request
1 task
Copy link
Member

@KinjiKawaguchi KinjiKawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

フォーマットで怒られてCi失敗しているので、フォーマッタを掛けてPushし直していただければ、Approveできます!

Copy link
Member

@KinjiKawaguchi KinjiKawaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KinjiKawaguchi KinjiKawaguchi merged commit 99bf10e into develop Apr 5, 2024
2 checks passed
@h-takeyeah h-takeyeah deleted the feat/game-screen/result-screen-button branch April 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]結果画面からの遷移実装
2 participants