Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CORS origin based on DEV_MODE #139

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Set CORS origin based on DEV_MODE #139

merged 4 commits into from
Dec 30, 2024

Conversation

KinjiKawaguchi
Copy link
Member

@KinjiKawaguchi KinjiKawaguchi commented Aug 8, 2024 •
edited
Loading

チケットへのリンク

やったこと

  • CORSのoriginをセット
  • APIの環境変数にDEV＿MODEを追加して、それに基づいてoriginを変更するように
  • docker composeも適切に変更。

@KinjiKawaguchi KinjiKawaguchi self-assigned this Aug 8, 2024
@h-takeyeah
Copy link
Collaborator

動作確認はした？

h-takeyeah
h-takeyeah previously approved these changes Sep 10, 2024
View reviewed changes
@KinjiKawaguchi
Copy link
Member Author

@h-takeyeah 動作確認Doneです．
変更入れたのでレビューいただけると

@h-takeyeah
Copy link
Collaborator

h-takeyeah commented Dec 12, 2024 •
edited
Loading

対応ありがとう！DEV_MODEをセットはしてるけど参照(読む)しているやつがいないのです 🥺

@h-takeyeah
Copy link
Collaborator

h-takeyeah commented Dec 12, 2024 •
edited
Loading

あと .env を追加した意図を書いておいてくださいませ(今までの実装でもよかったと思うけどなんで変えたの？)。個人的には.envを追加したことによってある程度長い文字列を書けるようになったのがメリットなのかなと思いました(もっというとなので.envにそのまま許可したいオリジンを列挙したらいいんじゃないのって思いました、if文書かなくて済むし)。

@KinjiKawaguchi
Copy link
Member Author

あ，composeで渡してたのか今まで戻しておきますん

@KinjiKawaguchi
Copy link
Member Author

直した．動作確認もした．mergeする

@KinjiKawaguchi KinjiKawaguchi merged commit 204a91f into main Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-takeyeah h-takeyeah h-takeyeah left review comments

Assignees

@KinjiKawaguchi KinjiKawaguchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORSを設定する
2 participants
@KinjiKawaguchi @h-takeyeah