Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/frontend/brushup #119

Merged
merged 16 commits into from
Apr 10, 2024
Merged

Feat/frontend/brushup #119

merged 16 commits into from
Apr 10, 2024

Conversation

arkwnet
Copy link
Contributor

@arkwnet arkwnet commented Apr 8, 2024 •
edited by h-takeyeah
Loading

チケットへのリンク

やったこと

  • ホーム画面のボタンを画像化
  • 背景画像追加
  • ファビコン変更
  • その他、レイアウト調整などフロントエンドのブラッシュアップ

Screenshot 2024-04-06 at 11-32-58 TYPE MASTER

h-takeyeah
h-takeyeah requested changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@h-takeyeah h-takeyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れさまでした。1点修正お願いします！

あとこれは修正依頼じゃないんですが、

<Box backgroundImage="url('/img/background.png');">

のように url を使ってる箇所があった(typing-app/src/app/layout.tsx)のですが、他のところはimport assetImage from "@/assets/path/to/image.png"のような書き方で書いてたのをあえてこちらで書いた理由がもしあれば教えてください！

typing-app/src/app/globals.css Show resolved Hide resolved
h-takeyeah
h-takeyeah previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@h-takeyeah h-takeyeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@KikyoNanakusa KikyoNanakusa merged commit 10db33c into develop Apr 10, 2024
2 checks passed
@h-takeyeah h-takeyeah deleted the feat/frontend/brushup branch April 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KinjiKawaguchi KinjiKawaguchi KinjiKawaguchi approved these changes

@h-takeyeah h-takeyeah h-takeyeah left review comments

Assignees

@arkwnet arkwnet

@h-takeyeah h-takeyeah

@KinjiKawaguchi KinjiKawaguchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]デザインを改善 by arkwさん
4 participants
@arkwnet @h-takeyeah @KinjiKawaguchi @KikyoNanakusa