Add failing test case #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
reviewed
Dec 30, 2021
| "ssr": true, | ||
| "topLevelImportPaths": [ | ||
| "@mui/material", | ||
| "@mui/material/*", |
There was a problem hiding this comment.
FWIW at HEAD right now this doesn't work. You need a regex. I have a PR to change this to picomatch
Open
2 tasks
|
Is this still an issue on v2.0.6? |
|
Not OP, but this PR is mentioned in open mui/material-ui#29742, so I guess it is still an issue. |
rbong
reviewed
Jul 30, 2022
| @@ -0,0 +1,14 @@ | |||
| import { styled as matStyled } from '@mui/material/styles'; | |||
| import sc from '@mui/material/styles'; | |||
| const Test1 = matStyled('div').withConfig({ | |||
There was a problem hiding this comment.
Do you really want it to transform matStyled? According to this issue this isn't wanted: #224
There was a problem hiding this comment.
We didn't want to do this in v4, because the styled there was not using styled-components. For v5, when the @mui/system is configured to use styled-components, we want the plugin to process these imports.
|
Hello, is there a plan how to fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this while debugging another problem.
babel-plugin-styled-componentsdoesn't recognise these imports: