Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Accept string resources for the HTML or Markdown conversion to PDF routes #30

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

stumpylog
Copy link
Owner

@stumpylog stumpylog commented Sep 26, 2024

This now includes accepting strings for resources which can be strings, such as the index.html or other resource files referred to by the index.html or primary Markdown file, such as fonts or CSS.

@stumpylog stumpylog added the enhancement New feature or request label Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.53%. Comparing base (7dfe72c) to head (f9e3f4e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/gotenberg_client/_base.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    99.60%   99.53%   -0.07%     
===========================================
  Files           25       25              
  Lines         1255     1289      +34     
===========================================
+ Hits          1250     1283      +33     
- Misses           5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog stumpylog linked an issue Sep 26, 2024 that may be closed by this pull request
@stumpylog stumpylog force-pushed the feature/accept_strings branch from 3c4dbd6 to 7a466dc Compare September 27, 2024 00:01
@stumpylog stumpylog changed the title Feature: Accept additional object types for the Chromium conversion to PDF routes Feature: Accept string resources for the Chromium conversion to PDF routes Sep 30, 2024
@stumpylog stumpylog force-pushed the feature/accept_strings branch 2 times, most recently from 484453c to 007be40 Compare September 30, 2024 17:15
@stumpylog stumpylog force-pushed the feature/accept_strings branch from 007be40 to f9e3f4e Compare October 8, 2024 20:47
@stumpylog stumpylog changed the title Feature: Accept string resources for the Chromium conversion to PDF routes Feature: Accept string resources for the HTML or Markdown conversion to PDF routes Oct 8, 2024
@stumpylog stumpylog merged commit 0313a91 into develop Oct 8, 2024
31 checks passed
@stumpylog stumpylog deleted the feature/accept_strings branch October 8, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass HTML variable to convert?
2 participants