Fix wrong PageSize for A4 (#24)

* Fix wrong PageSize for A4 Change the Letter size to be 8.5x11 and the A4 size to be actual A4 size. * Add Final to Letter PageSize * Update CHANGELOG.md --------- Co-authored-by: Trenton Holmes <[email protected]>
stumpylog · Jul 8, 2024 · 3ee137c · 3ee137c
1 parent b1d279b
commit 3ee137c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- Wrong paper size preset for A4 ([#24](https://github.com/stumpylog/gotenberg-client/pull/24))
+
 ## [0.6.0] - 2024-06-13
 
 ### Breaking Change

diff --git a/src/gotenberg_client/options.py b/src/gotenberg_client/options.py
@@ -65,10 +65,10 @@ def to_form(self) -> Dict[str, str]:
 A1: Final = PageSize(width=23.4, height=33.1)
 A2: Final = PageSize(width=16.54, height=23.4)
 A3: Final = PageSize(width=11.7, height=16.54)
-A4: Final = PageSize(width=8.5, height=11)
+A4: Final = PageSize(width=8.27, height=11.7)
 A5: Final = PageSize(width=5.83, height=8.27)
 A6: Final = PageSize(width=4.13, height=5.83)
-Letter = A4
+Letter: Final = PageSize(width=8.5, height=11)
 Legal: Final = PageSize(width=8.5, height=14)
 Tabloid: Final = PageSize(width=11, height=17)
 Ledge: Final = PageSize(width=17, height=11)

diff --git a/tests/test_convert_chromium_html.py b/tests/test_convert_chromium_html.py
@@ -94,8 +94,8 @@ def test_convert_page_size(self, client: GotenbergClient, httpx_mock: HTTPXMock)
             _ = route.index(test_file).size(A4).run()
 
         request = httpx_mock.get_request()
-        verify_stream_contains("paperWidth", "8.5", request.stream)
-        verify_stream_contains("paperHeight", "11", request.stream)
+        verify_stream_contains("paperWidth", "8.27", request.stream)
+        verify_stream_contains("paperHeight", "11.7", request.stream)
 
     def test_convert_margin(self, client: GotenbergClient, httpx_mock: HTTPXMock):
         httpx_mock.add_response(method="POST")