Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Terminate instances whose root element has been removed from the DOM #560

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Dec 4, 2024

πŸ”— Linked issue

#552

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

To avoid rogue instances that should not be kept alive, this PR adds a new mutation observer callback to destroy instances whose root element is no longer in the DOM.

  • Check if this works with the teleport logic of our Modal component
  • See if it is useful to push each test in the scheduler

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

github-actions bot commented Dec 4, 2024

Export Size

@studiometa/js-toolkit

Name Size Diff
createApp 1.27 kB +819 B (+180.40%) πŸ”Ί
HELPERS 2.42 kB +780 B (+47.45%) πŸ”Ί
FRAMEWORK 12.32 kB +102 B (+0.83%) πŸ”Ί
ALL 17.38 kB +92 B (+0.53%) πŸ”Ί
Unchanged

@studiometa/js-toolkit

Name Size Diff
AbstractService 478 B -
addClass 226 B -
addStyle 238 B -
animate 2.93 kB -
Base 7.47 kB -
BASE 7.54 kB -
boundingRectToCircle 154 B -
cache 133 B -
camelCase 401 B -
clamp 67 B -
clamp01 87 B -
collideCircleCircle 99 B -
collideCircleRect 159 B -
collidePointCircle 112 B -
collidePointRect 103 B -
collideRectRect 99 B -
createEaseInOut 116 B -
createEaseOut 71 B -
createElement 526 B -
createRange 90 B -
damp 78 B -
dashCase 376 B -
debounce 92 B -
DECORATORS 6.83 kB -
domScheduler 296 B -
DragService 1.84 kB -
ease 435 B -
easeInCirc 68 B -
easeInCubic 59 B -
easeInExpo 80 B -
easeInOutCirc 141 B -
easeInOutCubic 130 B -
easeInOutExpo 134 B -
easeInOutQuad 128 B -
easeInOutQuart 133 B -
easeInOutQuint 152 B -
easeInOutSine 151 B -
easeInQuad 63 B -
easeInQuart 61 B -
easeInQuint 62 B -
easeInSine 77 B -
easeLinear 49 B -
easeOutCirc 115 B -
easeOutCubic 103 B -
easeOutExpo 112 B -
easeOutQuad 103 B -
easeOutQuart 100 B -
easeOutQuint 103 B -
easeOutSine 121 B -
endsWith 88 B -
getAncestorWhere 91 B -
getAncestorWhereUntil 119 B -
getClosestParent 173 B -
getComponentResolver 138 B -
getDirectChildren 194 B -
getInstanceFromElement 90 B -
getInstances 146 B -
getOffsetSizes 159 B -
hasWindow 62 B -
historyPush 499 B -
historyReplace 503 B -
importOnInteraction 894 B -
importOnMediaQuery 236 B -
importWhenIdle 223 B -
importWhenPrefersMotion 275 B -
importWhenVisible 916 B -
inertiaFinalValue 142 B -
isArray 70 B -
isBoolean 78 B -
isDefined 86 B -
isDev 72 B -
isDirectChild 206 B -
isEmpty 207 B -
isEmptyString 93 B -
isFunction 72 B -
isNull 72 B -
isNumber 84 B -
isObject 105 B -
isString 86 B -
keyCodes 97 B -
KeyService 810 B -
lerp 57 B -
loadElement 169 B -
loadIframe 189 B -
loadImage 188 B -
loadLink 186 B -
loadScript 197 B -
LoadService 540 B -
lowerCase 60 B -
map 71 B -
matrix 106 B -
mean 91 B -
memo 100 B -
memoize 189 B -
MutationService 779 B -
nextFrame 162 B -
nextMicrotask 111 B -
nextTick 134 B -
noop 39 B -
noopValue 49 B -
objectToURLSearchParams 302 B -
pascalCase 377 B -
PointerService 1.02 kB -
Queue 226 B -
RafService 865 B -
randomInt 80 B -
randomItem 232 B -
removeClass 222 B -
removeStyle 238 B -
ResizeService 934 B -
round 56 B -
saveActiveElement 56 B -
ScrollService 972 B -
scrollTo 2.14 kB -
SERVICES 3.68 kB -
SmartQueue 411 B -
snakeCase 378 B -
startsWith 87 B -
throttle 101 B -
toggleClass 225 B -
transform 321 B -
transition 916 B -
trapFocus 363 B -
tween 1.56 kB -
untrapFocus 45 B -
upperCase 54 B -
useDrag 1.87 kB -
useKey 825 B -
useLoad 555 B -
useMutation 818 B -
usePointer 1.05 kB -
useRaf 877 B -
useResize 955 B -
useScheduler 290 B -
useScroll 993 B -
UTILS 7.48 kB -
wait 79 B -
withBreakpointManager 1.38 kB -
withBreakpointObserver 1.56 kB -
withDrag 1.99 kB -
withExtraConfig 135 B -
withFreezedOptions 140 B -
withIntersectionObserver 260 B -
withLeadingCharacters 88 B -
withLeadingSlash 107 B -
withMountOnMediaQuery 322 B -
withMountWhenInView 286 B -
withMountWhenPrefersMotion 355 B -
withMutation 936 B -
withName 81 B -
withoutLeadingCharacters 86 B -
withoutLeadingCharactersRecursive 124 B -
withoutLeadingSlash 93 B -
withoutTrailingCharacters 98 B -
withoutTrailingCharactersRecursive 129 B -
withoutTrailingSlash 103 B -
withRelativePointer 1.17 kB -
withResponsiveOptions 2.22 kB -
withScrolledInView 1.86 kB -
withTrailingCharacters 96 B -
withTrailingSlash 120 B -

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 98.97%. Comparing base (ab50f10) to head (427c089).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #560   +/-   ##
========================================
  Coverage    98.96%   98.97%           
========================================
  Files          122      122           
  Lines         4161     4178   +17     
  Branches      1132     1137    +5     
========================================
+ Hits          4118     4135   +17     
  Misses          43       43           
Flag Coverage Ξ”
unittests 98.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@titouanmathis titouanmathis marked this pull request as draft December 4, 2024 14:32
@titouanmathis titouanmathis force-pushed the feature/terminate-removed-instances branch from a1de2e8 to d8f6d14 Compare December 4, 2024 17:40
@titouanmathis titouanmathis marked this pull request as ready for review December 4, 2024 17:41
@titouanmathis titouanmathis merged commit b3e071f into develop Dec 4, 2024
14 checks passed
@titouanmathis titouanmathis deleted the feature/terminate-removed-instances branch December 4, 2024 17:47
@titouanmathis titouanmathis mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant