Remove usage of Timber\PostCollection in Repository

[perruche]

Motivation:

The abstract Repository must be more generic.

Removed

• references to Timber\PostCollection are removed
• Repository->slice() method is remove.

Closes #53 and #54

[titouanmathis]

Nice update, we should remove the mention of PostCollection from the doc blocks as well.

$this->result_set is an array, maybe we should lock the return value of $this->do_query() to be of type array instead of mixed? Cc @lusimeon @ptt-homme

[perruche]

All docblock comment's have been updated !

[titouanmathis]

question: Should we keep ArrayObject as an allowed type?

The PostQuery and PostCollection classes are base on PHP's ArrayObject class. Allowing the usage of ArrayObject results could help implement PostCollection or PostQuery in child classes.

Maybe we can discuss this next monday?

[perruche]

yes, can plan a meeting on the topic !
There is no PostQuery or PostCollection logic in this class since the do_query() method is to implement.
This could lead to some implementation with direct SQL query with wpdb for example

[perruche]

Any update on this merge request ?

[titouanmathis]

It seems good to me, I guess we will have to test it to see if the design is good.