Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the direction of the sort arrow #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kumabotz
Copy link

Arrow down - Descending
Arrow up - Ascending

Below are the screenshots for the direction of arrow used in Mac.

screen shot 2016-10-16 at 11 47 23 am

screen shot 2016-10-16 at 11 47 31 am

Arrow down - Descending
Arrow up - Ascending
@Wardrop
Copy link

Wardrop commented Mar 19, 2018

+1 I'd like to see this merged. @stuartlangridge

@Wardrop
Copy link

Wardrop commented Apr 3, 2018

This library seems a little unloved these days, and there's a lot of changes I'd like to see, so I decided just to roll-my-own. For anyone interested: https://github.com/Wardrop/Sorted.js

@stuartlangridge
Copy link
Owner

I wouldn't call it unloved -- I support it, still, and answer emails about it every day -- but you are of course welcome to fork it and make changes as you require; good luck with it! Looks like you're making some interesting changes.

On this particular issue, unfortunately, about 50% of people think that the sort arrows are in the wrong direction, and the other 50% think they're correct. I may change it in sorttable v3, after fifteen years of occasional complaints...

@Wardrop
Copy link

Wardrop commented Apr 3, 2018

Unloved may not be the right word, you're right.

How I solved this particular issue in Sorted.js was by putting the sort arrows in CSS, making them easily overidable for those with alternate preferences.

Likewise, feel free to take what you want from Sorted.js if you're planning a Sorttable v3. Sorttable obviously helped me considerably; Sorted.js is essentially just a refacting/re-imaging of Sorttable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants