Conversation
Matches the game.
Restore development port to 8881.
Updates sorting method for the voyage calc crew finder to (hopefully finally) match the in-game voyage crew selection. The new theory is that the first tiebreaker is the crew symbol in reverse order. This appears to be the case for both dilemma and encounter voyages. For the time being, the string comparison is forced to the `en` locale. This needs to be confirmed. The crew finder algorithm has also been revised to floor the voyage skill score before summing. This appears to yield more consistent sort results, but it needs to be confirmed with multiple-skill filtering. For encounter voyages, the initial sort appears to be range_max, with the first tiebreaker going to crew symbol in reverse order. Previous proposed sorting methods and tiebreakers have been removed from the code for clarity.
Fixes the voyage calc lineup editor so that the toplines and prospective configs properly take crew antimatter bonus into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.