fix CI

.github/workflows/android_build.yml

@@ -7,6 +7,10 @@ on:
     branches: [ master ]
   workflow_dispatch:
 
+permissions:
+  checks: write
+  pull-requests: write
+
 jobs:
   build:
 
@@ -37,4 +41,10 @@ jobs:
         run: ./gradlew build
 
       - name: Junit tests with Gradle
-        run: ./gradlew testDebugUnitTest
+        run: ./gradlew testDebugUnitTest
+
+      - name: Publish Test Results
+        uses: EnricoMi/publish-unit-test-result-action@v2
+        if: always()
+        with:
+          files: "**/build/test-results/**/*.xml"

app/src/test/java/com/stslex/aproselection/DiKoinModuleTest.kt

@@ -1,16 +1,18 @@
 package com.stslex.aproselection
 
 import android.content.Context
+import androidx.navigation.NavHostController
 import com.stslex.aproselection.core.datastore.coreDataStoreModule
+import com.stslex.aproselection.core.navigation.di.moduleCoreNavigation
 import com.stslex.aproselection.core.network.di.ModuleCoreNetwork.moduleCoreNetwork
-import com.stslex.aproselection.core.navigation.destination.NavigationScreen
+import com.stslex.aproselection.core.user.di.moduleCoreUser
 import com.stslex.aproselection.di.appModule
+import com.stslex.aproselection.di.initialAppModule
 import com.stslex.aproselection.feature.auth.di.ModuleFeatureAuth.moduleFeatureAuth
 import com.stslex.aproselection.feature.home.di.moduleFeatureHome
 import org.junit.Test
 import org.koin.android.ext.koin.androidContext
 import org.koin.dsl.koinApplication
-import org.koin.dsl.module
 import org.koin.test.KoinTest
 import org.koin.test.check.checkModules
 import org.mockito.Mockito
@@ -19,19 +21,17 @@ class DiKoinModuleTest : KoinTest {
 
     @Test
     fun checkKoinModules() {
-        val navigator: (screen: com.stslex.aproselection.core.navigation.destination.NavigationScreen) -> Unit = {}
+        val navController = Mockito.mock(NavHostController::class.java)
 
         koinApplication {
 
             androidContext(Mockito.mock(Context::class.java))
             modules(
-                module {
-                    single {
-                        navigator
-                    }
-                },
+                moduleCoreNavigation(navController),
+                initialAppModule,
                 appModule,
                 moduleCoreNetwork,
+                moduleCoreUser,
                 coreDataStoreModule,
                 moduleFeatureAuth,
                 moduleFeatureHome,

core/datastore/src/test/java/com/stslex/aproselection/core/datastore/CoreDataStoreModuleTest.kt

@@ -0,0 +1,22 @@
+package com.stslex.aproselection.core.datastore
+
+import android.content.Context
+import org.junit.Test
+import org.koin.android.ext.koin.androidContext
+import org.koin.dsl.koinApplication
+import org.koin.test.KoinTest
+import org.koin.test.check.checkModules
+import org.mockito.Mockito
+
+class CoreDataStoreModuleTest : KoinTest {
+
+    @Test
+    fun checkKoinModules() {
+
+        koinApplication {
+            androidContext(Mockito.mock(Context::class.java))
+            modules(coreDataStoreModule)
+            checkModules()
+        }
+    }
+}

core/navigation/src/test/java/com/stslex/aproselection/core/navigation/CoreNavigationModuleTest.kt

@@ -0,0 +1,25 @@
+package com.stslex.aproselection.core.navigation
+
+import android.content.Context
+import androidx.navigation.NavHostController
+import com.stslex.aproselection.core.navigation.di.moduleCoreNavigation
+import org.junit.Test
+import org.koin.android.ext.koin.androidContext
+import org.koin.dsl.koinApplication
+import org.koin.test.KoinTest
+import org.koin.test.check.checkModules
+import org.mockito.Mockito
+
+class CoreNavigationModuleTest : KoinTest {
+
+    @Test
+    fun checkKoinModules() {
+        val navController = Mockito.mock(NavHostController::class.java)
+
+        koinApplication {
+            androidContext(Mockito.mock(Context::class.java))
+            modules(moduleCoreNavigation(navController))
+            checkModules()
+        }
+    }
+}

core/network/src/main/java/com/stslex/aproselection/core/network/clients/user/UserNetworkClientImpl.kt

@@ -3,12 +3,12 @@ package com.stslex.aproselection.core.network.clients.user
 import com.stslex.aproselection.core.network.client.NetworkClient
 import com.stslex.aproselection.core.network.clients.user.model.UpdateUserInfoBody
 import com.stslex.aproselection.core.network.clients.user.model.UserResponse
-import com.stslex.aproselection.core.network.model.PagingRequest
 import io.ktor.client.call.body
 import io.ktor.client.request.get
 import io.ktor.client.request.post
 import io.ktor.client.request.setBody
 import io.ktor.http.appendPathSegments
+import io.ktor.util.AttributeKey
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
 
@@ -22,12 +22,10 @@ class UserNetworkClientImpl(
     ): List<UserResponse> = withContext(Dispatchers.IO) {
         networkClient.apiClient.get {
             url.appendPathSegments("user", "list")
-            setBody(
-                PagingRequest(
-                    pageSize = pageSize,
-                    pageNumber = page
-                )
-            )
+            setAttributes {
+                put(AttributeKey("page_size"), pageSize)
+                put(AttributeKey("page_number"), page)
+            }
         }.body()
     }
 

core/network/src/test/java/com/stslex/aproselection/core/network/ModuleCoreNetworkTest.kt

@@ -1,6 +1,7 @@
 package com.stslex.aproselection.core.network
 
 import android.content.Context
+import com.stslex.aproselection.core.datastore.coreDataStoreModule
 import com.stslex.aproselection.core.network.di.ModuleCoreNetwork.moduleCoreNetwork
 import org.junit.Test
 import org.koin.android.ext.koin.androidContext
@@ -15,7 +16,10 @@ class DiKoinModuleTest : KoinTest {
     fun checkKoinModules() {
         koinApplication {
             androidContext(Mockito.mock(Context::class.java))
-            modules(moduleCoreNetwork)
+            modules(
+                moduleCoreNetwork,
+                coreDataStoreModule
+            )
             checkModules()
         }
     }

core/ui/src/main/java/com/stslex/aproselection/core/ui/base/BasePagingSource.kt

@@ -32,6 +32,6 @@ class BasePagingSource<T : Any>(
     }
 
     companion object {
-        const val INITIAL_PAGE_NUMBER = 1
+        const val INITIAL_PAGE_NUMBER = 0
     }
 }

core/user/build.gradle.kts

@@ -7,4 +7,6 @@ android.namespace = "com.stslex.aproselection.core.user"
 dependencies {
     implementation(project(":core:core"))
     implementation(project(":core:network"))
+    testImplementation(project(":core:core"))
+    androidTestImplementation(project(":core:core"))
 }

core/user/src/test/java/com/stslex/aproselection/core/user/CoreUserModuleTest.kt

@@ -0,0 +1,32 @@
+package com.stslex.aproselection.core.user
+
+import android.content.Context
+import com.stslex.aproselection.core.network.clients.user.UserNetworkClient
+import com.stslex.aproselection.core.user.di.moduleCoreUser
+import org.junit.Test
+import org.koin.android.ext.koin.androidContext
+import org.koin.core.KoinApplication
+import org.koin.dsl.koinApplication
+import org.koin.dsl.module
+import org.koin.test.KoinTest
+import org.koin.test.check.checkModules
+import org.mockito.Mockito
+
+class CoreUserModuleTest : KoinTest {
+
+    @Test
+    fun checkKoinModules() {
+        koinApplication {
+            androidContext(Mockito.mock(Context::class.java))
+            load<UserNetworkClient>()
+            modules(moduleCoreUser)
+            checkModules()
+        }
+    }
+
+    private inline fun <reified T> KoinApplication.load() {
+        koin.loadModules(
+            listOf(module { single<T> { Mockito.mock(T::class.java) } })
+        )
+    }
+}

feature/auth/src/test/java/com/stslex/aproselection/feature/auth/ModuleFeatureAuthTest.kt

@@ -1,11 +1,15 @@
 package com.stslex.aproselection.feature.auth
 
 import android.content.Context
-import com.stslex.aproselection.core.network.di.ModuleCoreNetwork.moduleCoreNetwork
+import com.stslex.aproselection.core.datastore.AppDataStore
+import com.stslex.aproselection.core.navigation.navigator.Navigator
+import com.stslex.aproselection.core.network.clients.auth.AuthNetworkClient
 import com.stslex.aproselection.feature.auth.di.ModuleFeatureAuth.moduleFeatureAuth
 import org.junit.Test
 import org.koin.android.ext.koin.androidContext
+import org.koin.core.KoinApplication
 import org.koin.dsl.koinApplication
+import org.koin.dsl.module
 import org.koin.test.KoinTest
 import org.koin.test.check.checkModules
 import org.mockito.Mockito
@@ -16,11 +20,17 @@ class ModuleFeatureAuthTest : KoinTest {
     fun checkKoinModules() {
         koinApplication {
             androidContext(Mockito.mock(Context::class.java))
-            modules(
-                moduleFeatureAuth,
-                moduleCoreNetwork
-            )
+            load<Navigator>()
+            load<AuthNetworkClient>()
+            load<AppDataStore>()
+            modules(moduleFeatureAuth)
             checkModules()
         }
     }
+
+    private inline fun <reified T> KoinApplication.load() {
+        koin.loadModules(
+            listOf(module { single<T> { Mockito.mock(T::class.java) } })
+        )
+    }
 }

feature/home/src/test/java/com/stslex/aproselection/feature/home/ModuleFeatureHomeTest.kt

@@ -0,0 +1,34 @@
+package com.stslex.aproselection.feature.home
+
+import android.content.Context
+import com.stslex.aproselection.core.datastore.AppDataStore
+import com.stslex.aproselection.core.user.data.repository.UserRepository
+import com.stslex.aproselection.feature.home.di.moduleFeatureHome
+import org.junit.Test
+import org.koin.android.ext.koin.androidContext
+import org.koin.core.KoinApplication
+import org.koin.dsl.koinApplication
+import org.koin.dsl.module
+import org.koin.test.KoinTest
+import org.koin.test.check.checkModules
+import org.mockito.Mockito
+
+class ModuleFeatureHomeTest : KoinTest {
+
+    @Test
+    fun checkKoinModules() {
+        koinApplication {
+            androidContext(Mockito.mock(Context::class.java))
+            load<UserRepository>()
+            load<AppDataStore>()
+            modules(moduleFeatureHome)
+            checkModules()
+        }
+    }
+
+    private inline fun <reified T> KoinApplication.load() {
+        koin.loadModules(
+            listOf(module { single<T> { Mockito.mock(T::class.java) } })
+        )
+    }
+}