Skip to content

Keep error dialog from displaying #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Keep error dialog from displaying #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions static/js/directives/screenshare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,21 @@ define(['jquery', 'underscore', 'text!partials/screenshare.html', 'text!partials
$scope.stopScreenshare();
}
}, function(err) {
console.log("Screen sharing request returned error", err);
alertify.dialog.alert(translation._("Failed to start screen sharing (%s).", err));
var errMsg = '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not define as empty string and provide reference where this error handling comes from? When does err.detail ever exist?

var errCode = '';
if (err && err.detail) {
errMsg = err.detail;
errCode = err.errorCode;
} else {
errMsg = err;
}
console.log("Screen sharing request returned error", errMsg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please log full err.

// Do not display error dialog when user cancelled action of
// chrome extension installation
// https://developer.chrome.com/extensions/webstore#type-ErrorCode
if (errCode !== 'userCancelled') {
alertify.dialog.alert(translation._("Failed to start screen sharing (%s).", errMsg));
}
$scope.stopScreenshare();
});

Expand Down