Fix compilation on Windows with /std:c++latest #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling libde265 on Windows using MSVC 2019 and the latest C++ standard preview (which is C++20), I get the following error: `error C4496: nonstandard extension 'for each' used: replace with ranged-for statement` The similar issue arises when using clang-cl. Actually, MSVC supports ranged-for statement since MSVC 2012, and has full C++11 support for `auto` since MSVC 2015 (reference: https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140)?redirectedfrom=MSDN); `_MSC` version code for MSVC 2015 is `1900`. Hence the easy fix.
|
I just hit this as well while trying to compile the library using |
|
@farindk Hi Dirk, can you merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling libde265 on Windows using MSVC 2019 and the latest C++ standard preview (which is C++20), I get the following error:
error C4496: nonstandard extension 'for each' used: replace with ranged-for statementThe similar issue arises when using clang-cl.
Actually, MSVC supports ranged-for statement since MSVC 2012, and has full C++11 support for
autosince MSVC 2015 (reference);_MSC_VERversion code for MSVC 2015 is1900. Hence the easy fix.