This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Allow another name convention for User model and AccessToken model #26
Open
clark0x
wants to merge
1
commit into
strongloop-archive:master
Choose a base branch
from
clark0x:fix/built-in-models-not-found
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,7 @@ describe('helpers', function () { | |
it('should have an xxx-test-model property', function () { | ||
assert(this['xxx-test-model']); | ||
assert(this['xxx-test-model'].id); | ||
assert(this['xxx-test-model'] instanceof testModel); | ||
}); | ||
}); | ||
|
||
|
@@ -109,4 +110,42 @@ describe('helpers', function () { | |
}); | ||
}); | ||
}); | ||
|
||
describe('helpers.beforeEach.givenUser', function() { | ||
describe('with default user model', function() { | ||
testApp.model(loopback.User, {dataSource: 'db'}); | ||
helpers.beforeEach.givenUser({ email: '[email protected]', password: '000000' }); | ||
it('should create an user of User type', function () { | ||
assert(this['user'] instanceof loopback.User); | ||
}); | ||
}); | ||
describe('with custom User model', function() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if we have multiple custom user models? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. multiple custom user models won't work properly, check discuss here: strongloop/loopback#527 |
||
var Account = loopback.User.extend('Account'); | ||
testApp.model(Account, {dataSource: 'db'}); | ||
helpers.beforeEach.withApp(testApp, { User: 'Account' }); | ||
helpers.beforeEach.givenUser({ email: '[email protected]', password: '000000' }); | ||
it('should create an user of Account type', function () { | ||
assert(this.user instanceof Account); | ||
}); | ||
}); | ||
}); | ||
|
||
describe('helpers.beforeEach.givenAnUnauthenticatedToken', function() { | ||
describe('with default AccessToken model', function() { | ||
testApp.model(loopback.AccessToken, {dataSource: 'db'}); | ||
helpers.beforeEach.givenAnUnauthenticatedToken({}); | ||
it('should create an accessToken of AccessToken type', function () { | ||
assert(this.accessToken instanceof loopback.AccessToken); | ||
}); | ||
}); | ||
describe('with custom AccessToken model', function() { | ||
var Token = loopback.AccessToken.extend('Token'); | ||
testApp.model(Token, {dataSource: 'db'}); | ||
helpers.beforeEach.withApp(testApp, { AccessToken: 'Token' }); | ||
helpers.beforeEach.givenAnUnauthenticatedToken({}); | ||
it('should create an accessToken of Token type', function () { | ||
assert(this.accessToken instanceof Token); | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be options.AccessToken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin-lau
this
doesn't point to the test object.'AccessToken'
is the key ofoptions
, it will be use to retrieve the configured model name in_beforeEach#givenModel()
.