Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Drop peer dependency on loopback #14

Merged
merged 1 commit into from
Jun 12, 2014
Merged

Conversation

bajtos
Copy link
Contributor

@bajtos bajtos commented Jun 6, 2014

The peer dependency was used to control which loopback versions
we are compatible with. Unfortunately it does not work well, e.g.
even when the peer dep allows loopback 2.x, npm installs 1.x version
instead.

/to @ritch please review

The peer dependency was used to control which loopback versions
we are compatible with. Unfortunately it does not work well, e.g.
even when the peer dep allows loopback 2.x, npm installs 1.x version
instead.
@ritch
Copy link
Contributor

ritch commented Jun 10, 2014

This will potentially bite users. For example #15 might end up requiring changes in loopback that break compatibility with older versions of this module. The only way to find that out is will be really odd - hard to catch bugs in your tests.

What if we just wrote a simple version check like this:

var pkg = require('./package.json');
var loopbackPkg = require('loopback/package.json');
var isCompatible = semver.satisfies(loopbackPkg.version, pkg.loopbackVersion);

if(!isCompatible) {
  throw new Error('incompatible loopback version');
}

Either way, I am all for removing this as it has probably hurt more than helped.

👍

bajtos added a commit that referenced this pull request Jun 12, 2014
@bajtos bajtos merged commit 25be2d7 into master Jun 12, 2014
@bajtos
Copy link
Contributor Author

bajtos commented Jun 12, 2014

Let's move the discussion to #18.

@bajtos bajtos deleted the feature/drop-loopback-peer-dep branch June 12, 2014 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants