Upgrade extension to latest testing libraries, update README, and VSCode version #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matv-stripe
force-pushed
the
matv/upgradeversionandreadme
branch
from
8ff884e to
2dbc2ef
Compare
matv-stripe
changed the title
Comment on lines
-37
to
-63
| "onView:stripeEventsView", | ||
| "onView:stripeLogsView", | ||
| "onView:stripeQuickLinksView", | ||
| "onView:stripeHelpView", | ||
| "onCommand:stripe.createStripeSample", | ||
| "onCommand:stripe.createWebhookEndpoint", | ||
| "onCommand:stripe.login", | ||
| "onCommand:stripe.openCLI", | ||
| "onCommand:stripe.openWebhooksListen", | ||
| "onCommand:stripe.openDashboardApikeys", | ||
| "onCommand:stripe.openDashboardLogs", | ||
| "onCommand:stripe.openDashboardEvents", | ||
| "onCommand:stripe.openDashboardWebhooks", | ||
| "onCommand:stripe.openEventDetails", | ||
| "onCommand:stripe.openTriggerEvent", | ||
| "onCommand:stripe.openCreateCustomizedEvent", | ||
| "onCommand:stripe.openTriggerCustomizedEvent", | ||
| "onCommand:stripe.openReportIssue", | ||
| "onCommand:stripe.openDocs", | ||
| "onCommand:stripe.openSurvey", | ||
| "onCommand:stripe.openSamples", | ||
| "onCommand:stripe.startLogsStreaming", | ||
| "onCommand:stripe.stopLogsStreaming", | ||
| "onCommand:stripe.clearRecentLogs", | ||
| "onCommand:stripe.clearRecentEvents", | ||
| "onCommand:stripe.startEventsStreaming", | ||
| "onCommand:stripe.stopEventsStreaming", |
There was a problem hiding this comment.
Do we need to get rid of these activation events? I suppose the onView ones are noop because the extension would've already been active when you view them but the onCommand ones seem important.
There was a problem hiding this comment.
(This is @matv) - in newer version of VSCode, the linter suggested I remove these.
https://code.visualstudio.com/api/references/activation-events#onCommand
Note: Beginning with VS Code 1.74.0, commands contributed by your extension do not require a corresponding onCommand activation event declaration for your extension to be activated.
vcheung-stripe
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the README with instructions to how to get the extension to run.
It also updates the minimum VSCode version to allow us to use newer APIs.
It also upgrades the tests to pass in Github Actions. This required some debugging, but it ended up being because I needed to upgrade
vscode-testto a newer version and update the platform for windows. In the future, as we update the extension, the first spot we should look should be outdated NPM packages.I did not bump the package version just yet because I do not want to make a release (no new functionality has been added).