Skip to content

Allow underscores in font names on Android for PaymentSheet appearance #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −7
Open

Allow underscores in font names on Android for PaymentSheet appearance #1637

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a5d46f
change regex to allow for underscore in android font name
Apr 5, 2024
2130904
update wording in error to reflect underscores being allowed
Apr 5, 2024
898512c
Merge branch 'fontunderscoreandroid' into font_name_android
Apr 29, 2025
6729c9d
Merge pull request #1 from goguda/font_name_android
Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions android/src/main/java/com/reactnativestripesdk/PaymentSheetAppearance.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,14 +521,11 @@ private fun getFontResId(
return defaultValue
}

val fontFileName =
bundle.getString(key)
?: throw PaymentSheetAppearanceException(
"$fontErrorPrefix expected String for font.$key, but received null.",
)
if (Regex("[^a-z0-9]").containsMatchIn(fontFileName)) {
val fontFileName = bundle.getString(key)
?: throw PaymentSheetAppearanceException("$fontErrorPrefix expected String for font.$key, but received null.")
if (Regex("[^a-z0-9_]").containsMatchIn(fontFileName)) {
throw PaymentSheetAppearanceException(
"$fontErrorPrefix appearance.font.$key should only contain lowercase alphanumeric characters on Android, but received '$fontFileName'. This value must match the filename in android/app/src/main/res/font",
"$fontErrorPrefix appearance.font.$key should only contain lowercase alphanumeric characters and underscores on Android, but received '$fontFileName'. This value must match the filename in android/app/src/main/res/font"
)
}

Expand Down
Loading