Complete BatchingTopicController refactoring: handler classes #10248
+1,874
−2,038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scalability comparison with the same custom test.
|
|
Failed test is unrelated and working when running locally. |
tombentley
reviewed
Jun 25, 2024
This change completes the BatchingTopicController refactoring by introduicing a set of handlers, one for each external system, that host the request logic. With that, the BatchingTopicController class is only focused on the reconciliation logic, resulting in 40% less code and better maintenance. Tested with all Topic Operator unit and integration tests, TopicST, and TopicReplicasChangeST. I also ran the scalability test comparing this branch with 0.41.0, and the performance doesn't change. Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
to-btc-ref-handlers
branch
5 times, most recently
from
4ccda8a
to
cad9cde
Compare
Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
to-btc-ref-handlers
branch
from
cad9cde
to
ad53e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This change completes the BatchingTopicController refactoring by introduicing a set of handlers, one for each external system, that host the request logic. With that, the BatchingTopicController class is only focused on the reconciliation logic, resulting in 40% less code and better maintenance.
Tested with all Topic Operator unit and integration tests, TopicST, and TopicReplicasChangeST. I also ran the scalability test comparing this branch with 0.41.0, and the performance doesn't change.
Checklist