_codegen: add license and merge package 'imports' #1797
Conversation
Merge code from package internal/imports (recently copied from package github.com/ernesto-jimenez/gogen/imports) into the codegen program itself. Also copy the license attached to it into the _codegen/main.go source, as _codegen/main.go was originally by the same author (Ernesto Jimenez) as the imported code and matches the license terms of the global Testify project. Also: Ernesto, who was queried about this project, didn't block it. #1782 (comment)
| Copyright (c) 2015,2016 Ernesto Jiménez | ||
| Copyright (c) 2019 Leigh McCulloch | ||
| Copyright (c) 2020 Matt Gorzka | ||
| Copyright (c) 2024 Simon Schulte | ||
| Copyright (c) 2023,2025 Olivier Mengué |
There was a problem hiding this comment.
This is unusual and would require careful attention to keep up to date. Follow the same pattern as testify and allow VCS to be the source of the names:
Line 3 in 6c30310
| Copyright (c) 2015,2016 Ernesto Jiménez | |
| Copyright (c) 2019 Leigh McCulloch | |
| Copyright (c) 2020 Matt Gorzka | |
| Copyright (c) 2024 Simon Schulte | |
| Copyright (c) 2023,2025 Olivier Mengué | |
| Copyright (c) 2015-2025 Ernesto Jiménez and contributors. |
There was a problem hiding this comment.
I was tempted to do that, but to stay on the safe side, I chose to mention all contributors I found in the Git history.
As this is not really engineering, but legal stuff, I would be more confident if I you could give me some references to back the choice of a particular style of copyright mentions.
There was a problem hiding this comment.
I can't give you the original decision to claim on behalf of the contributors because it's not written down, but in addition to what is already done in our own source code I found this in my research: https://opensource.stackexchange.com/questions/4960/can-a-team-be-the-copyright-holder-mit
We should be consistent with ourselves.
2 participants
Summary
Merge code from package internal/imports (recently copied from package github.com/ernesto-jimenez/gogen/imports) into the codegen program itself. Also copy the license attached to it into the _codegen/main.go source, as _codegen/main.go was originally by the same author (@ernesto-jimenez) as the imported code and matches the license terms of the global Testify project.
Also: @ernesto-jimenez who was queried about this project, didn't block it. #1782 (comment)
Changes
_codegen/internal/imports.impinto _codegen/main.go asimports._codegen/internal/importsthat isn't need anymoreMotivation
Reduce code in _codegen
Related issues
This a follow-up to #1782.