assert: add Kind #1049
Open
assert: add Kind #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
added
enhancement
pkg-assert
dolmen
requested changes
Jun 2, 2025
| } | ||
|
|
||
| // Kind check if the given object is of the given type | ||
| func Kind(t TestingT, expected reflect.Kind, object interface{}) bool { |
There was a problem hiding this comment.
Add msgAndArgs parameter like in other functions.
| if reflect.TypeOf(object).Kind() == expected { | ||
| return true | ||
| } | ||
| return false |
| {m["bar"], "something", false, ""}, | ||
| {myType("1"), myType("2"), false, ""}, | ||
| {time.Date(2020, 3, 1, 12, 23, 14, 0, time.UTC), time.Date(2020, 5, 1, 12, 23, 14, 0, time.UTC), true, ""}, | ||
| {time.Date(2020, 6, 3, 12, 23, 14, 0, time.UTC), time.Date(2020, 8, 3, 12, 23, 14, 0, time.UTC), true, ""}, |
There was a problem hiding this comment.
This change doesn't seem related.
| {myType("1"), myType("1"), true, ""}, | ||
| {&struct{}{}, &struct{}{}, true, "pointer equality is based on equality of underlying value"}, | ||
| {time.Date(2020, 3, 1, 12, 23, 14, 0, time.UTC), time.Date(2020, 3, 1, 12, 23, 14, 0, time.UTC), true, ""}, | ||
| {time.Date(2020, 6, 3, 12, 23, 14, 0, time.UTC), time.Date(2020, 6, 3, 12, 23, 14, 0, time.UTC), true, ""}, |
There was a problem hiding this comment.
This change doesn't seem related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added assert.Kind to the given object is of the given type.(issue #633)