Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libuser.py #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update libuser.py #5

wants to merge 7 commits into from

Conversation

streichsbaer
Copy link
Owner

@streichsbaer streichsbaer commented Jan 26, 2024

No description provided.

bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
bad/libuser.py Fixed Show fixed Hide fixed
@@ -44,7 +44,21 @@


def password_change(username, password):

# Issue
subprocess.Popen([password], shell=1-1)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yeah that's a bad one.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuk what do i need to do to fix it?!

# Issue
subprocess.Popen([password], shell=1-1)
# Issue
subprocess.Popen([password], shell=True)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
# Issue
subprocess.Popen([password], shell=True)
# Issue
subprocess.call([password], shell=True)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
# Issue
subprocess.call([password], shell=True)
# Issue
subprocess.run([password], shell=0+1)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
# Issue
subprocess.run([password], shell=0+1)
# Issue
subprocess.run(username + password, shell=2-3)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
# Issue
subprocess.run(username + password, shell=2-3)
# Not an issue
subprocess.run(username + password, shell=2-2)

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
# Not an issue
subprocess.run(username + password, shell=2-2)
# Not an issue
subprocess.run(["{}/Triton/ensemble/fil_backend/scripts/convert_sklearn".format(password), model_path

Check failure

Code scanning / CodeQL

Uncontrolled command line Critical

This command line depends on a
user-provided value
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant