Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Database interface #6119

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Cleanup Database interface #6119

merged 6 commits into from
Feb 10, 2025

Conversation

FloEdelmann
Copy link
Member

In preparation for #5417, which I started looking into.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you are? That's cool!

By the way, there is probably little reason to keep the Database interface when the database dealing stuff has been migrated to that multiplatform-enabled thing. (We'll see)

@FloEdelmann
Copy link
Member Author

there is probably little reason to keep the Database interface

But we will need to keep the AndroidDatabase class (renamed to something better of course) as a wrapper around the multiplatform SQLite library, because that library is quite bare-bones. Is it better to then refer to that class everywhere? Or should we keep the interface and let the class implement it, just like it is now?

@westnordost
Copy link
Member

You are probably right about this. The interface of that library is pretty bare-bones and thus it would be less convenient (and more error-prone) to use it directly.

@westnordost westnordost merged commit feca687 into master Feb 10, 2025
@FloEdelmann FloEdelmann deleted the sqlite branch February 11, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants