-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to match with newest Validators version and enforce Pandas <2 until new duckdb is released #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tszerszen
changed the title
Fix ruff linting
Update code to match with newest Validators version and fix Pandas 2.1 support by enforcing newest version of Duckdb
Sep 22, 2023
sfc-gh-tszerszen
requested review from
sfc-gh-dmatthews and
sfc-gh-jcarroll
September 22, 2023 12:29
blackary
reviewed
Sep 22, 2023
blackary
reviewed
Sep 22, 2023
blackary
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but a couple of questions
sfc-gh-dmatthews
approved these changes
Sep 22, 2023
Good by me to merge once questions from Zachary addressed. TY!!! |
Thank you all for the review 🙇 Please address my comment about |
sfc-gh-tszerszen
changed the title
Update code to match with newest Validators version and fix Pandas 2.1 support by enforcing newest version of Duckdb
Update code to match with newest Validators version and enforce Pandas <2 until new duckdb is released
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of
gsheets-connection
is broken due to:validators
package renamed its functionsduckdb
lost compatibility withpandas>=2.1.0
This PR addresses above problems by:
validators
version insetup.py
and changing thegsheets-connection
code to support newest API (Kudos to @sfc-gh-dmatthews for finding last working version and the reason behind the failure in the following commit.duckdb==0.8.1
does not supportpandas>=2
so I enforcedpandas <2
untilduckdb==0.8.2
is releasedAlso this PR introduced some minor linting fixes to keep compatibility with
ruff
.