Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The remote? method should allow for files with http in their names #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hlascelles
Copy link

If a filename has an http(s) in the name it is mistaken for a remote:

# filename: /tmp/movie_of_http_webpage.mov

# Run:

     Failure/Error: response = http.request_head(url.request_uri)
     
     NoMethodError:
       undefined method `request_uri' for #<URI::Generic:0x00005640e7574d78>

The search for http(s) should be at the start of the string.

@hlascelles hlascelles changed the title The remote? method should allow for fils with http in their names The remote? method should allow for files with http in their names Nov 20, 2020
@hlascelles
Copy link
Author

@streamio Do you need any more information on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant