Issue/88-outstanding-608-prs #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
Additional checks to ensure that we don't go out of bonds. Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
ported changes from video-dev/hls.js#6427 Signed-off-by: Agajan Jumakuliyev <[email protected]>
ported changes from video-dev/hls.js#6427 Signed-off-by: Agajan Jumakuliyev <[email protected]>
SccParser from Dash IF. Instead of reading from file, lines: string is an argument of parse method. Signed-off-by: Agajan Jumakuliyev <[email protected]>
Ported over changes from Dash-Industry-Forum/dash.js#3719 Signed-off-by: Agajan Jumakuliyev <[email protected]>
Signed-off-by: Agajan Jumakuliyev <[email protected]>
agajassi
force-pushed
the
issue/88-outstanding-608-prs
branch
from
8b8541e
to
725dee6
Compare
littlespex
reviewed
Jun 5, 2024
Signed-off-by: Casey Occhialini <[email protected]>
littlespex
reviewed
Jun 5, 2024
Signed-off-by: Casey Occhialini <[email protected]>
littlespex
approved these changes
Jun 5, 2024
littlespex
reviewed
Jun 5, 2024
Signed-off-by: Casey Occhialini <[email protected]>
littlespex
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Create extractCea608DataFromSample.ts * Create seiHelpers.ts * Update extractCea608DataFromSample.ts * Update seiHelpers.ts * Update getCharForByte.ts * ported changes from video-dev/hls.js#6427 * Create SccParser.ts * Update Cta608Parser.ts --------- Signed-off-by: Agajan Jumakuliyev <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves issue/88
Ported over following CTA 608 parser related bug fix PRs from Dash IF, Dash.js and HLS.js projects.
Dash-Industry-Forum/cea608.js#3
Dash-Industry-Forum/dash.js#3719
video-dev/hls.js#6427
Requirements Checklist