Add cancel request to retry transport#17
Open
tchakabam wants to merge 4 commits intostreadway:masterfrom
Open
Conversation
… timeout and re-use the connection)
… go default http client
tchakabam
changed the title
Owner
There was a problem hiding this comment.
A nit - is that 'fib' now becomes a bound variable, so I'm pretty sure a unique 'fib' func will get compiled for every call of Fibonacci the compiler should discover that fib contains no free variables and reuse an implementation, but I'd err on the side of being nice to the compiler and leave fib a package function.
This reverts commit 9f9feaa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@streadway Otherwise the wrapping http.Client can't make use of its timeout feature
see http://golang.org/src/pkg/net/http/client.go line 300