Skip to content

fix specs incompatibilities#2165

Merged
plebhash merged 2 commits into
stratum-mining:mainfrom
GitGab19:specs-incompatibilities
May 30, 2026
Merged

fix specs incompatibilities#2165
plebhash merged 2 commits into
stratum-mining:mainfrom
GitGab19:specs-incompatibilities

Conversation

@GitGab19

Copy link
Copy Markdown
Member

This PR adapts our crates to recent changes merged on specs: stratum-mining/sv2-spec#196.

Closes #2150

@GitGab19 GitGab19 force-pushed the specs-incompatibilities branch from acef8f4 to 76ff2df Compare May 29, 2026 10:19
@plebhash

plebhash commented May 30, 2026

Copy link
Copy Markdown
Member

reviewing from mobile

spec changes from stratum-mining/sv2-spec#196:

  • SetCustomMiningJob/.Success/.Error channel_msg bit ✅ fixed + test against regression
  • PushSolution field ordering ✅ fixed + test against regression
  • NewMiningJob channel_msg bit 🚫 no fix needed, SRI already had the correct behavior

the only thing I'm not able to do now is a sanity check on version bumps

will double check that later but overall LGTM

@Shourya742 Shourya742 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@plebhash plebhash merged commit e86cb02 into stratum-mining:main May 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spec incompatibilities

3 participants