-
Notifications
You must be signed in to change notification settings - Fork 3
Increase GitHub Action checkout version to v5 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase GitHub Action checkout version to v5 #114
Conversation
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
WalkthroughUpdated .github/workflows/main.yml by upgrading actions/checkout from v4 to v5 in two steps and adding persist-credentials: false to each checkout step. No other workflow structure or commands changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/main.yml (1)
35-37
: actions/checkout@v5 + persist-credentials: false — upgrade verified; no legacy checkout, no submodules, no history-dependent tools detectedScan results:
- No other
actions/checkout@v1|2|3|4
usages in .github- No .gitmodules file present
- No
setuptools-scm
,use_scm_version
, orgit describe/rev-parse/log
calls foundOptional hardening recommendations:
- Pin the checkout action to a specific commit SHA (or enable Dependabot) to reduce supply-chain risk.
- If you ever need full git history or submodule support, add
fetch-depth: 0
and/orsubmodules: true
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/main.yml
(2 hunks)
🔇 Additional comments (1)
.github/workflows/main.yml (1)
69-71
: Consistent upgrade in the second job — LGTMThe second checkout is also correctly bumped to v5 with credentials persistence disabled. Same optional notes about pinning and history/submodules apply if relevant.
Related stratis-storage/project#807
Summary by CodeRabbit