-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update packages to resolve package security audits #17
Conversation
🦋 Changeset detectedLatest commit: 73710cd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Does anyone know if these upgrades will potentially affect the linting/prettier downstream? If so, this might need to be a major version bump. If not, it can just be a patch. I might release it as a beta so we can test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I'm only curious about whether it'll impact the prettier formatting in the types generation 🤔
Did you notice any differences?
it doesn't run any eslint for the user. just reads the tsconfig. I think it's using prettier for some stuff so might be worth check what exactly |
Released @strapi/[email protected] to test this directly in @strapi/strapi and make sure nothing breaks |
For anyone who wants to check, I released experimental So I'll merge and release this as a |
What does it do?
Updates a myriad of packages to fix
CVE-2024-4068 (braces)
CVE-2024-31207 (vite)
CVE-2024-4067 (micromatch)
Why is it needed?
security
How to test it?
everything should still work
Related issue(s)/PR(s)