fix: remove commander build option fallbacks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18fe8e8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@joshuaellis I'm not sure if this is the desired change, we0 also could make the config file always overwrite the commander options, and then the default values can be kept. |
|
Hey @MattieBelt - cheers for your patience, we've lifted the code freeze now that Strapi 5 has been launched and will be reviewing this shortly. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes build option usage in
packup.config.jsWhy is it needed?
The commander build options are merged with the option from
packup.config.js, but as the commander options have a fallback value even if the option isn't set the option will overwrite the value from the config file. The fallback value for vite is also set in thetasks/vite/config.Related PRs
#12