Fixing unit testing docs for Strapi 5 #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… these docs are only for JS strapi projects
kasonde
added
source: Dev Docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pwizla
reviewed
Dec 6, 2024
docusaurus/docs/dev-docs/testing.md
Outdated
| @@ -11,7 +11,7 @@ tags: | |||
| # Unit testing | |||
|
|
|||
| :::strapi | |||
There was a problem hiding this comment.
Suggested change
| :::strapi | |
| :::info |
There was a problem hiding this comment.
Recommending this because "strapi" callouts are purely to higlight attention on important cross-links or other (internal/external) resources for readers.
Also, why are we removing these links? Is their content outdated too?
There was a problem hiding this comment.
@pwizla no problem, I'll make that change.
Also yes, the links directly mimic the docs and they are outdated since they do not have Strapi 5 versions from what I saw.
|
Thank you, @kasonde! Just a minor comment and I can merge it whenever you think it's appropriate. |
|
Made the change @pwizla :) |
pwizla
added
temp: port to doc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates the Unit testing documents to work with Strapi 5 Javascript projects
Why is it needed?
In correct code examples in the unit testing documentation.
Related issue
#1940