SDK 47+ unsafe-reset w/ backwards compatibility #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
(cherry picked from commit 482dee8)
|
@Mergifyio backport v7 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
(cherry picked from commit 482dee8)
Reecepbcups
added a commit
that referenced
this pull request
Sep 7, 2023
(cherry picked from commit 482dee8) Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Colin's comment
Summary
With this, it is now possible to unsafe reset all in the legacy SDK (v45, 46) while also maintaining support for the newer
cometnamespace to reset all.Since the new genesis command was also introduced at the same time, we just check that if it's on.
Future considerations
We may want to change
UsingNewGenesisCommandto beUsingOldGenesisCommandto opt in for older SDK versions (since all future versions will use this new format)